Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add busy-timeout-interval setting #620

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

darkgnotic
Copy link
Contributor

@darkgnotic darkgnotic commented Dec 9, 2024

Adds a busy-timeout yaml setting that adjusts the PRAGMA busy_timeout in litestream to handle applications that hold the lock for longer than the default value of 1 second.

(i.e. the converse of setting the https://litestream.io/tips/#busy-timeout in the application)

Copy link
Owner

@benbjohnson benbjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the name from "busy timeout interval" to just "busy timeout"? It's not really an interval since it's not repeating. Otherwise the PR looks good.

@darkgnotic
Copy link
Contributor Author

Can you change the name from "busy timeout interval" to just "busy timeout"? It's not really an interval since it's not repeating. Otherwise the PR looks good.

Ah, good point! Done!

@benbjohnson benbjohnson merged commit 996a50d into benbjohnson:main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants